Skip to content

Extract stylish-haskell plugin into a standalone package#1604

Merged
berberman merged 2 commits into
haskell:masterfrom
berberman:stylish-haskell-package
Mar 22, 2021
Merged

Extract stylish-haskell plugin into a standalone package#1604
berberman merged 2 commits into
haskell:masterfrom
berberman:stylish-haskell-package

Conversation

@berberman

Copy link
Copy Markdown
Collaborator

Following #1422

@pepeiborra pepeiborra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@berberman
berberman merged commit 5724343 into haskell:master Mar 22, 2021
@berberman
berberman deleted the stylish-haskell-package branch March 22, 2021 13:49
@prikhi

prikhi commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

This commit broke formatting w/ stylish-haskell for me(via coc.nvim).

On this commit, launching HLS w/ -d doesn't show PluginId "stylish-haskell" in LspArguments plugin list. On the commit before this one, it does.

@berberman

Copy link
Copy Markdown
Collaborator Author

Hi, thanks for the bug report! I just realized that cpp-options: -D was removed accidently from common stanza, so the plugin was not actually wired in HLS. I'm afraid brittany plugin had the same problem. /cc @pepeiborra

@prikhi

prikhi commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

hehe, I just submitted a PR w/ the same fix 😛
#1620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants