Implement refine imports#1686
Merged
Merged
Conversation
Ailrun
reviewed
Apr 7, 2021
Ailrun
reviewed
Apr 8, 2021
Ailrun
reviewed
Apr 8, 2021
Collaborator
|
🆒 |
pepeiborra
reviewed
Apr 17, 2021
pepeiborra
reviewed
Apr 17, 2021
pepeiborra
reviewed
Apr 17, 2021
pepeiborra
reviewed
Apr 17, 2021
pepeiborra
requested changes
Apr 17, 2021
Collaborator
|
To run in CI the test suite needs to be added to https://github.com/haskell/haskell-language-server/blob/master/.github/workflows/test.yml |
pepeiborra
requested changes
Apr 27, 2021
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Let's add the test suite to CI before merging
Member
|
nix jobs has failed with rerunning the jobs just in case |
Collaborator
The Nix commit hooks were not pinned correctly and now they have broken. @Ailrun could you take a look? |
pepeiborra
approved these changes
Apr 29, 2021
Member
|
Sure, let me check that tomorrow. |
Contributor
Author
|
hooray! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
A plugin which can refine the imports to use the underlying modules instead of the aggregated one.
For example, assuming there is a module A what it does is only importing and immediately exporting module B and module C, and there is a Main module importing A for a value which is defined in module B. This plugin can provide a click to change from import A to import B.
That is, from
to
Why?
One reason of long building time is because the unnecessary dependencies imported. In above example, module C is an unnecessary dependency.
This provides a fast way to cut down the size of dependencies.