Wingman: maintain user-defined fixity for definitions

[isovector]

This PR makes Wingman respect user-defined fixities when performing case splits. However, if the user didn't explicitly bind any arguments, it will choose to use infix for a symbolically-named functions.

Fixes #1610

[isovector]

This is now fixed upstream. I plan to tackle it later tonight if time permits.

[isovector]

@berberman nix builds seem to be failing --- any idea what's up?

[berberman]

@berberman nix builds seem to be failing --- any idea what's up?

Don't worry, nix/build jobs are broken because this PR introduces ghc-source-gen-0.4.1.0 which nix doesn't know. The jobs are not in branch protection rules and can be fixed later (which only affect creating binaries for nix).

For people who are interested this, the fix would be just overriding ghc-source-gen-0.4.1.0 here:

haskell-language-server/flake.nix

Lines 71 to 86 in b8bb06e

	tweaks = hself: hsuper:
	with haskell.lib; {
	hls-tactics-plugin = hsuper.hls-tactics-plugin.override {
	refinery = hself.refinery_0_3_0_0;
	};
	hiedb = hself.callCabal2nix "hiedb"
	(builtins.fetchTarball {
	url =
	"https://hackage.haskell.org/package/hiedb-0.4.0.0/hiedb-0.4.0.0.tar.gz";
	sha256 =
	"13jz8c46zfpf54ya2wsv4akhn0wcfc6qjazqsjfir5gpvsi7v8xr";
	}) { };
	};

[isovector]

Tests (minus nix) are green!

[Ailrun]

Thank you, LGTM.

[isovector]

CI is hitting this actions/checkout#23, which claims to be fixed but clearly isn't.

[isovector]

@berberman , it appears CI for 9.0.1 is broken. The error I get is this:

Cloning into '/home/runner/work/haskell-language-server/haskell-language-server/dist-newstyle/src/operation_-2cf41f8926150174'...
fatal: reference is not a tree: 0e062895678f49fd673ae493371262cfb8c5ab56

but only on 9.0.1. So I dug in, and noticed that commit referenced in stack-9.0.1.yaml. But it no longer appears to exist on your branch, I'm guessing because it was deleted after being merged here: HeinrichApfelmus/operational#26

[isovector]

Blocked by #2016

[isovector]

\o/