Bracketing for snippet completions#1709
Merged
mergify[bot] merged 16 commits intoApr 13, 2021
Merged
Conversation
pepeiborra
requested changes
Apr 11, 2021
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
I left a comment in the original issue on why I am skeptical that this is an improvement.
… with no arguments no longer bracketed
pepeiborra
requested changes
Apr 12, 2021
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Nice job!
It looks like a symbolic link was accidentally deleted - please restore it before merging.
pepeiborra
approved these changes
Apr 12, 2021
Ailrun
approved these changes
Apr 13, 2021
konn
approved these changes
Apr 13, 2021
konn
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍
Sorry for late reaction, and thank you for the implementation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1700
This can easily be changed to the first variation suggested in the issue (without typed holes).
I'm not sure how to write a test case for this.