Skip to content

Pin nix-pre-commit-hooks#1780

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
Ailrun:master
Apr 30, 2021
Merged

Pin nix-pre-commit-hooks#1780
mergify[bot] merged 1 commit into
haskell:masterfrom
Ailrun:master

Conversation

@Ailrun

@Ailrun Ailrun commented Apr 29, 2021

Copy link
Copy Markdown
Member

This PR supersede #1779.

Fixes this GitHub nix action issue:

error: attribute 'run' missing, at /Users/runner/work/haskell-language-server/haskell-language-server/nix/default.nix:83:24
(use '--show-trace' to show detailed location information)
Error: Process completed with exit code 1.

@Ailrun
Ailrun requested a review from pepeiborra April 29, 2021 19:41
pepeiborra
pepeiborra approved these changes Apr 29, 2021
View reviewed changes

@pepeiborra pepeiborra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra pepeiborra mentioned this pull request Apr 29, 2021
Closed
@Ailrun Ailrun added the merge me Label to trigger pull request merge label Apr 29, 2021
@mergify
mergify Bot merged commit 6bd6cf0 into haskell:master Apr 30, 2021
@Ailrun

Ailrun commented May 5, 2021

Copy link
Copy Markdown
Member Author

@Mergifyio backport 1.1.0-hackage

mergify Bot pushed a commit that referenced this pull request May 5, 2021
@Ailrun
Pin nix-pre-commit-hooks (#1780)
deffb33 
(cherry picked from commit 6bd6cf0)
@mergify mergify Bot mentioned this pull request May 5, 2021
Merged
@mergify

mergify Bot commented May 5, 2021

Copy link
Copy Markdown
Contributor

Command backport 1.1.0-hackage: success

Backports have been created

@Ailrun

Ailrun commented May 5, 2021

Copy link
Copy Markdown
Member Author

CI on 1.1.0-hackage keeps failing because of this, so it'd be better to backport this.

jneira pushed a commit that referenced this pull request May 5, 2021
@mergify @Ailrun
Pin nix-pre-commit-hooks (#1780) (#1798)
1b3868a 
(cherry picked from commit 6bd6cf0)

Co-authored-by: Junyoung/Clare Jang <jjc9310@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ailrun @pepeiborra