Progress reporting improvements#1784
Merged
Merged
Conversation
pepeiborra
force-pushed
the
progressreport-redo
branch
from
May 2, 2021 10:56
b3ba386 to
793be94
Compare
pepeiborra
marked this pull request as ready for review
May 2, 2021 14:36
ndmitchell
approved these changes
May 3, 2021
ndmitchell
left a comment
Collaborator
There was a problem hiding this comment.
I see a few updates to the test - are these fixing race conditions that this patch showed up?
This code is way clearer!
Collaborator
Author
I fixed a bunch of tests in the previous version of this PR and decided to preserve the fixes. Not necessarily race conditions: often tests rely on sketchy invariants, e.g. a test that waits for three logging notifications before checking if the build session is restarted is going to break for reasons unrelated to the property it's checking. |
pepeiborra
force-pushed
the
progressreport-redo
branch
from
May 3, 2021 08:01
7c40949 to
7fc92b1
Compare
pepeiborra
force-pushed
the
progressreport-redo
branch
from
May 3, 2021 08:13
7fc92b1 to
3850495
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of #1770. Summary of changes:
window/workDoneProgress/createby waiting until the client has respondedtodois 0) and handling whenNoProgressI think this is the best we can do to close #1749 while sharing the same logic for both tests and app code