Loosen dependency bounds#1787
Merged
Merged
Conversation
pepeiborra
approved these changes
May 2, 2021
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
I hope this works. I wish we had some way of testing these changes in CI
Collaborator
Author
|
@Mergifyio backport 1.1.0-hackage |
Contributor
|
Command
|
mergify Bot
pushed a commit
that referenced
this pull request
May 3, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> (cherry picked from commit 9308ff4) # Conflicts: # plugins/hls-refine-imports-plugin/hls-refine-imports-plugin.cabal
Contributor
|
Command
|
Ailrun
pushed a commit
that referenced
this pull request
May 3, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> (cherry picked from commit 9308ff4) # Conflicts: # plugins/hls-refine-imports-plugin/hls-refine-imports-plugin.cabal Co-authored-by: Potato Hatsue <1793913507@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've decided to stick to the PVP, we are able to relax the lower bounds of
hls-plugin-api,ghcide, andhls-test-utils. We should also bp this PR to 1.1.0-hackage, the branch where we are going to upload hls-1.1.0 to Hackage, so that #1725 can be closed legitimately without doing Hackage revisions.