Extract floskell plugin as a standalone plugin#1829
Merged
Conversation
Ailrun
force-pushed
the
extract-floskell-plugin
branch
from
May 13, 2021 17:38
7dcb0d5 to
d63e1b5
Compare
Member
Author
|
Cabal configuration fails for benchmark with the following message: Maybe we need to increase the max backjump limit? (I tried 5000, and that at least works in my machine) Edit: In CI, 5000 does not work... Edit2: I didn't know that cabal's backjump is non-deterministic. Sometimes 5000 does not work in my machine either... |
Ailrun
force-pushed
the
extract-floskell-plugin
branch
from
May 14, 2021 02:53
6022bdc to
9892dd2
Compare
Ailrun
force-pushed
the
extract-floskell-plugin
branch
from
May 14, 2021 03:15
9892dd2 to
9b4936d
Compare
jneira
approved these changes
May 14, 2021
jneira
left a comment
Member
There was a problem hiding this comment.
It looks really great (including improvements in tests), many thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its basic structure is copied from
hls-brittany-plugin.