Fix getCurrentDirectory calls in ghcide#1897
Merged
Merged
Conversation
Collaborator
Author
|
#1894 is open to test these changes with lsp HEAD |
berberman
approved these changes
Jun 6, 2021
fix uses of getCurrentDirectory in ghcide
pepeiborra
force-pushed
the
fix-getCurrentDirectory-calls
branch
from
June 6, 2021 17:19
f8531df to
6bd3338
Compare
pepeiborra
force-pushed
the
fix-getCurrentDirectory-calls
branch
from
June 6, 2021 17:24
6bd3338 to
f5bc01a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsp HEAD no longer sets the current directory to the workspace root (haskell/lsp#326) so we need to remove this assumption from the ghcide codebase. There are 3 places where this is relevant:
loadCradle, or rather, in the GHC session returned by it, where any relative paths in the flags returned by the cradle will expect to be resolved from the directory where thehie.yamlfile lives - should change the working directory to the hie.yaml locationsetInitialDynFlags, where we search for ahie.yamlfile in the current directory - should use the workspace root instead