Skip to content

Add support for ghc-8.8.4#206

Merged
alanz merged 3 commits into
haskell:masterfrom
jneira:ghc-8.8.4
Jul 17, 2020
Merged

Add support for ghc-8.8.4#206
alanz merged 3 commits into
haskell:masterfrom
jneira:ghc-8.8.4

Conversation

@jneira

@jneira jneira commented Jul 17, 2020

Copy link
Copy Markdown
Member
  • Updating hackage index to get last version of ghc-exactprint, compatible with ghc-8.8.4
  • Adding a stack-8.8.4.yaml using the last ghc-8.8.3 resolver but informing explicitly compiler: ghc-8.8.4

I am getting errors compiling floskell in windows, but it is reproduced with other ghc versions. I get to compile downloading floskell locally and adding it as subpackage in cabal.project.
To report upstream 🤷‍♂️ : ennocramer/floskell#50

@jneira jneira changed the title Add support for ghc-8.4.4 Add support for ghc-8.8.4 Jul 17, 2020

@Ailrun Ailrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@alanz
alanz merged commit 751428c into haskell:master Jul 17, 2020
@jneira
jneira deleted the ghc-8.8.4 branch July 17, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants