Parallel fuzzy filtering#2225
Merged
Merged
Conversation
jneira
reviewed
Sep 21, 2021
pepeiborra
force-pushed
the
parallel-fuzzy
branch
from
September 21, 2021 11:12
4266d57 to
5c4063b
Compare
pepeiborra
marked this pull request as ready for review
September 21, 2021 20:49
jneira
reviewed
Sep 22, 2021
jneira
approved these changes
Sep 22, 2021
jneira
left a comment
Member
There was a problem hiding this comment.
Not sure if there are existing tests which might be changed to cover changes, i let it to your consideration
Collaborator
Author
All the completions test suite cover these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2215 and #2217 this is another performance improvement to completions driven by the large Sigma codebase.
On every completion attempt we need to match the prefix against all the identifiers in the project, with a cost of O(Identifiers*C) where C is the average number of characters per identifier. This PR parallelises the matching and uses vectors to reduce the amount of allocations and enable in-place sorting of the results.