Trace rebuilds#2283
Merged
Merged
Conversation
pepeiborra
force-pushed
the
trace-rebuilds
branch
from
October 21, 2021 11:11
3ab6ebb to
cb4c256
Compare
pepeiborra
force-pushed
the
trace-rebuilds
branch
from
October 21, 2021 16:30
cb4c256 to
f342001
Compare
michaelpj
reviewed
Oct 21, 2021
| @@ -239,8 +239,8 @@ stderrLogger logLevel = do | |||
| telemetryLogger :: IO Logger | |||
| telemetryLogger | |||
| | userTracingEnabled = return $ Logger $ \p m -> | |||
Collaborator
There was a problem hiding this comment.
withEventTrace also contains this guard. You could remove it; but that would change this from a single check of userTracingEnabled to create a no-op Logger to a check of userTracingEnabled on every step. Not sure if that's bad, but probably worth a comment to make it clear it's a deliberate decision if so.
Collaborator
Author
There was a problem hiding this comment.
good shout, I'll add a comment
as pointed out by @michaelpj the check is already installed in withTracing the logger should not make any assumptions regarding user tracing being static anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more tracing to investigate module rebuilds and key dirtiness