ghcide: Update dependency on hls-plugin-api#2382
Merged
Merged
Conversation
Contributor
Author
|
When building Building |
2204a16 broke backward compatibility between `ghcide` and `hls-plugin-api`
hololeap
force-pushed
the
ghcide-deps
branch
from
November 21, 2021 16:11
99ea691 to
f203a23
Compare
jneira
approved these changes
Nov 22, 2021
jneira
left a comment
Member
There was a problem hiding this comment.
lgtm, will need hackage revision
Member
|
Member
|
@hololeap all revisions done, many thanks for help us to keep correct bounds //cc @pepeiborra |
hololeap
added a commit
to hololeap/gentoo-haskell
that referenced
this pull request
Nov 27, 2021
Restrict versions of dependency `hls-plugin-api` Bug: haskell/haskell-language-server#2382 Fix typo in `src_configure()` Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: hololeap <hololeap@users.noreply.github.com>
hololeap
added a commit
to hololeap/gentoo-haskell
that referenced
this pull request
Nov 29, 2021
Restrict versions of dependency `hls-plugin-api` Bug: haskell/haskell-language-server#2382 Fix typo in `src_configure()` Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: hololeap <hololeap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2204a16 broke backward compatibility between
ghcideandhls-plugin-apiIn addition to this PR, the following will need to be revised on hackage:
Versions
1.4.1.01.4.2.01.4.2.11.4.2.21.4.2.3will needhls-plugin-api ^>= 1.2.0.0changed to
hls-plugin-api >= 1.2.0.0 && < 1.2.0.2Version
1.5.0will needhls-plugin-api ^>= 1.2.0.0changed to
hls-plugin-api ^>= 1.2.0.2