Skip to content

ghcide: Update dependency on hls-plugin-api#2382

Merged
mergify[bot] merged 2 commits into
haskell:masterfrom
hololeap:ghcide-deps
Nov 22, 2021
Merged

ghcide: Update dependency on hls-plugin-api#2382
mergify[bot] merged 2 commits into
haskell:masterfrom
hololeap:ghcide-deps

Conversation

@hololeap

@hololeap hololeap commented Nov 21, 2021

Copy link
Copy Markdown
Contributor

2204a16 broke backward compatibility between ghcide and hls-plugin-api

In addition to this PR, the following will need to be revised on hackage:

Versions 1.4.1.0 1.4.2.0 1.4.2.1 1.4.2.2 1.4.2.3 will need
hls-plugin-api ^>= 1.2.0.0
changed to
hls-plugin-api >= 1.2.0.0 && < 1.2.0.2

Version 1.5.0 will need
hls-plugin-api ^>= 1.2.0.0
changed to
hls-plugin-api ^>= 1.2.0.2

@hololeap

Copy link
Copy Markdown
Contributor Author

When building ghcide-1.4.2.2 on top of hls-plugin-api-1.2.0.2:

src/Development/IDE/Types/Options.hs:140:29: error:
    Data constructor not in scope: CheckOnSaveAndClose :: CheckParents
    |
140 |     ,optCheckParents = pure CheckOnSaveAndClose
    |                             ^^^^^^^^^^^^^^^^^^^

Building ghcide-1.4.2.2 on top of hls-plugin-api-1.2.0.1 works correctly

2204a16 broke backward compatibility
between `ghcide` and `hls-plugin-api`

@jneira jneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will need hackage revision

@jneira jneira added the merge me Label to trigger pull request merge label Nov 22, 2021
@mergify
mergify Bot merged commit 0a55e9c into haskell:master Nov 22, 2021
@jneira

jneira commented Nov 22, 2021

Copy link
Copy Markdown
Member

@hololeap all revisions done, many thanks for help us to keep correct bounds //cc @pepeiborra

@hololeap
hololeap deleted the ghcide-deps branch November 22, 2021 10:44
hololeap added a commit to hololeap/gentoo-haskell that referenced this pull request Nov 27, 2021
Restrict versions of dependency `hls-plugin-api`
Bug: haskell/haskell-language-server#2382

Fix typo in `src_configure()`

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
hololeap added a commit to hololeap/gentoo-haskell that referenced this pull request Nov 29, 2021
Restrict versions of dependency `hls-plugin-api`
Bug: haskell/haskell-language-server#2382

Fix typo in `src_configure()`

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants