Disable check project in the ghcide test suite#2397
Merged
Conversation
pepeiborra
force-pushed
the
disable-checkProject
branch
from
November 25, 2021 12:47
d12cf1b to
a1ba81d
Compare
pepeiborra
marked this pull request as ready for review
November 25, 2021 18:53
pepeiborra
force-pushed
the
disable-checkProject
branch
from
November 25, 2021 23:26
a1ba81d to
8dfb998
Compare
This is a bit ugly, but we already do it in defaultMain I also realized I don't really understand the HLS config options anymore.
pepeiborra
force-pushed
the
disable-checkProject
branch
from
November 26, 2021 15:13
a218779 to
45eacd5
Compare
Member
|
Will merge as soon as #2393 is merged, thanks! |
jneira
approved these changes
Nov 28, 2021
jneira
left a comment
Member
There was a problem hiding this comment.
lgtm, hope this will improve test suite flakyness, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkProject setting introduces (even more) non determinism and leads to flaky tests as seen in #2153
This PR disables it in the ghcide test suite, except in the tests that explicitly exercise the setting