Delete some dead or deprecated settings

[michaelpj]

Perhaps controversially, I also removed the disabled tests for diagnostics-on-save and Liquid Haskell. They're in the history if someone wants to resurrect those features.

I'm not very happy with the section in the docs about this: ideally it would display some sensible auto-generated table of settings or something...

[pepeiborra]

where is hlintOn used? Suspicious

[eddiemundo]

The hlint plugin does use it in its GetHlintDiagnostics rule

[michaelpj]

Thanks, this one I foolishly assumed that the comment in the doc was all there was - more purging to do.

[eddiemundo]

Oh I understand now nevermind...

[jneira]

hlintOn is in the plugin for backwards compat in the deprecation process but that was time ago so it can be deleted
@michaelpj feel free to remove it here or we can do later

[jneira]

The build in circleci and stack is failing due to -Werror=unused-imports:

haskell-language-server           > /root/build/test/functional/Diagnostic.hs:6:1: error: [-Wunused-imports, -Werror=unused-imports]
haskell-language-server           >     The import of ‘Data.Aeson’ is redundant
haskell-language-server           >       except perhaps to import instances from ‘Data.Aeson’
haskell-language-server           >     To import instances alone, use: import Data.Aeson()
haskell-language-server           >   |
haskell-language-server           > 6 | import           Data.Aeson              (toJSON)
haskell-language-server           >   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
haskell-language-server           > 
haskell-language-server           > /root/build/test/functional/Diagnostic.hs:7:1: error: [-Wunused-imports, -Werror=unused-imports]
haskell-language-server           >     The qualified import of ‘Data.Default’ is redundant
haskell-language-server           >       except perhaps to import instances from ‘Data.Default’
haskell-language-server           >     To import instances alone, use: import Data.Default()
haskell-language-server           >   |
haskell-language-server           > 7 | import qualified Data.Default
haskell-language-server           >   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
haskell-language-server           > 
haskell-language-server           > /root/build/test/functional/Diagnostic.hs:8:1: error: [-Wunused-imports, -Werror=unused-imports]
haskell-language-server           >     The import of ‘Ide.Plugin.Config’ is redundant
haskell-language-server           >       except perhaps to import instances from ‘Ide.Plugin.Config’
haskell-language-server           >     To import instances alone, use: import Ide.Plugin.Config()
haskell-language-server           >   |
haskell-language-server           > 8 | import           Ide.Plugin.Config
haskell-language-server           >   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
haskell-language-server           > 

[jneira]

nice to see a +6-87 in a pr, thanks for the xmas clean up! 🎅

[jneira]

is not the deactivation handled automatically and generically by hls-plugin-api?

[michaelpj]

I have no idea how this works 😅 If I do that then the test that changing the config works starts timing out 🤷

[jneira]

hmm ok i think we should change noHlintDiagnostics for

noHlintDiagnostics :: Assertion
noHlintDiagnostics  = expectNoMoreDiagnostics 3 doc "hlint"

to avoid the parser hang on some diagnostic which never is emitted (not sure why it works keeping the if but 🤷 )

[michaelpj]

Do you mind if I leave that as a future improvement, and leave this PR as just getting rid of the old settings?

[michaelpj]

I think I've purged hlintOn properly now.