Send unhandled exceptions to the user by pepeiborra · Pull Request #2484 · haskell/haskell-language-server

pepeiborra · 2021-12-13T21:56:10Z

jneira · 2021-12-15T06:27:41Z

The test suite for tactics has failed ~~twice~~ several times for windows 8.10.7, with different test error cases, not sur if it will be transient

This cancelled job had 7 attempts and the tactics test suite failed in the 6 first ones

Anton-Latukha · 2021-12-15T11:05:17Z

Recent failed test workflows were:
pepeiborra - https://github.com/haskell/haskell-language-server/runs/4513326877?check_suite_focus=true
AntonLatukha - https://github.com/haskell/haskell-language-server/runs/4527885363?check_suite_focus=true (before that I & CI skipped my previous restart of a workflow, because right after it I decided not just restart, but also do a sync at the same time)
jneira - https://github.com/haskell/haskell-language-server/runs/4530467808?check_suite_focus=true

pepeiborra · 2021-12-15T23:54:05Z

The last failure is due to the old sqlite3 hiedb problem, not something specific to this change. We have a ticket for it somewhere, but I am on my phone right now and can't look.

We have a couple of sources of flakiness, and I would appreciate if someone would find the time to look into the hiedb one. Why is it getting triggered? Is the test suite running tests in parallel?

SQLite3 returned ErrorBusy while attempting to perform step: database is locked\n",

pepeiborra · 2021-12-16T10:40:41Z

Added code to stop the hiedb on shutdown. Might or might not help

michaelpj · 2021-12-16T11:57:01Z


+-- | Runs the action until it ends or until the given MVar is put.
+--   Rethrows any exceptions.
+untilMVar :: MonadUnliftIO m => MVar () -> m () -> m ()


Kind of surprised these sorts of utilities aren't available elsewhere. I couldn't find them, anyway.

Especially the pattern of forking a thread with an MVar to control terminating it 🤔

They may exist, I'm not sure either.

michaelpj · 2021-12-16T15:44:23Z

The windows jobs seemed to be hanging (stuck for 4h). I attempted to cancel them but it's unclear that it's worked.

michaelpj · 2021-12-16T16:02:08Z

... how did that work?

jneira · 2021-12-16T17:24:05Z

... how did that work?

it should not 😕
the test post-jobs was supposed to be cancelled but it was not
https://github.com/haskell/haskell-language-server/runs/4549724494?check_suite_focus=true

michaelpj · 2021-12-17T09:48:00Z

I think this might be making the ghcide tests hang on windows. I think we should revert it until we can confirm.

jneira · 2021-12-17T10:35:11Z

I think this might be making the ghcide tests hang on windows. I think we should revert it until we can confirm.

~~well i have a pr fixing the cancelling thing and including this pr, if its tests are not stuck it would be fine~~

After reading your comment in #2493 it seems so
I am gonna revert it in my fork to check it, i have a pr in my fork with is also stuck: jneira#55 so the problem is reproduced there too

This reverts commit 0211f75.

jneira · 2021-12-17T10:42:37Z

pr in my fork with this reverted jneira#56

jneira · 2021-12-17T12:08:07Z

Ok the pr in my fork with this reverted has passed the ghcide tests: https://github.com/jneira/haskell-language-server/runs/4559275575?check_suite_focus=true
I am gonna open here

This reverts commit 0211f75.

This reverts commit 5d2189c.

* Revert "Revert "Send unhandled exceptions to the user (#2484)" (#2497)" This reverts commit 5d2189c. * Log when reactor thread exits * log shakeSessionInit * Do not assume that the build has been initialized

michaelpj approved these changes Dec 13, 2021

View reviewed changes

Comment thread ghcide/src/Development/IDE/LSP/LanguageServer.hs Outdated

Comment thread ghcide/src/Development/IDE/LSP/LanguageServer.hs Outdated

Comment thread ghcide/src/Development/IDE/LSP/LanguageServer.hs

pepeiborra force-pushed the unhandled-exceptions branch from 58eca00 to 9d875c2 Compare December 13, 2021 23:15

pepeiborra added the merge me Label to trigger pull request merge label Dec 13, 2021

michaelpj approved these changes Dec 14, 2021

View reviewed changes

pepeiborra added 5 commits December 16, 2021 09:33

Send unhandled exceptions to the user

83ae7af

send message in server exception too

90a4b14

add missing signature

8479178

fix redundant imports

870df21

Release hiedb on shutdown

a044156

pepeiborra force-pushed the unhandled-exceptions branch from af13ef7 to a044156 Compare December 16, 2021 10:31

pepeiborra requested a review from michaelpj December 16, 2021 10:50

michaelpj approved these changes Dec 16, 2021

View reviewed changes

mergify Bot merged commit 0211f75 into master Dec 16, 2021

jneira added a commit to jneira/haskell-language-server that referenced this pull request Dec 17, 2021

Revert "Send unhandled exceptions to the user (haskell#2484)"

edd544e

This reverts commit 0211f75.

jneira mentioned this pull request Dec 17, 2021

Revert "Send unhandled exceptions to the user (#2484)" #2497

Merged

pepeiborra pushed a commit that referenced this pull request Dec 18, 2021

Revert "Send unhandled exceptions to the user (#2484)" (#2497)

5d2189c

This reverts commit 0211f75.

pepeiborra added a commit that referenced this pull request Dec 18, 2021

Revert "Revert "Send unhandled exceptions to the user (#2484)" (#2497)"

6968b80

This reverts commit 5d2189c.

pepeiborra added a commit that referenced this pull request Dec 19, 2021

Revert "Revert "Send unhandled exceptions to the user (#2484)" (#2497)"

3c65b5c

This reverts commit 5d2189c.

eddiemundo mentioned this pull request Dec 23, 2021

Fix random SQLite busy database is locked errors #2527

Merged

Uh oh!

Uh oh!

Conversation

pepeiborra commented Dec 13, 2021 • edited by gitpod-io Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jneira commented Dec 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anton-Latukha commented Dec 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pepeiborra commented Dec 15, 2021

Uh oh!

pepeiborra commented Dec 16, 2021

Uh oh!

Uh oh!

Uh oh!

michaelpj Dec 16, 2021

Choose a reason for hiding this comment

Uh oh!

michaelpj Dec 16, 2021

Choose a reason for hiding this comment

Uh oh!

pepeiborra Dec 16, 2021

Choose a reason for hiding this comment

Uh oh!

michaelpj commented Dec 16, 2021

Uh oh!

michaelpj commented Dec 16, 2021

Uh oh!

jneira commented Dec 16, 2021

Uh oh!

michaelpj commented Dec 17, 2021

Uh oh!

jneira commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jneira commented Dec 17, 2021

Uh oh!

jneira commented Dec 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pepeiborra commented Dec 13, 2021 •

edited by gitpod-io Bot

Loading

jneira commented Dec 15, 2021 •

edited

Loading

Anton-Latukha commented Dec 15, 2021 •

edited

Loading

jneira commented Dec 17, 2021 •

edited

Loading