Disable alternate numbers format plugin temporary#2498
Merged
Conversation
michaelpj
reviewed
Dec 17, 2021
Ailrun
approved these changes
Dec 17, 2021
Ailrun
left a comment
Member
There was a problem hiding this comment.
LGTM other than the hackage issue mentioned above. Here's some minor suggestion:
drsooch
approved these changes
Dec 17, 2021
jneira
force-pushed
the
disable-alternate-numbers
branch
from
December 17, 2021 21:30
e93ba89 to
7d99b25
Compare
Member
Author
no needed technically but needed anyways, thanks! |
pepeiborra
pushed a commit
that referenced
this pull request
Dec 19, 2021
* Disable alternateNumberFormat temporary * Disable alternateNumberFormat tests * Add a warn in docs * Add link to issue in docs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jneira
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Use `extQ` to choose parser. - In the process of development, it was forgotten that the "parent" type of patterns and exprs is different. When traversal occurs, SYB would throw out `Pat` types as it was only expecting `HsExpr` types. - Using `extQ` allows us to chain the expected types and we can then destructure patterns appropriately. * Revert "Disable alternate numbers format plugin temporary (#2498)" This reverts commit 15d7402.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cabal install -falternateNumberFormat