Skip to content

CI: caching: keep-going#2535

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
Anton-Latukha:2021-12-23-all-dep-solve-fault-rolerant-cache
Dec 23, 2021
Merged

CI: caching: keep-going#2535
mergify[bot] merged 1 commit into
haskell:masterfrom
Anton-Latukha:2021-12-23-all-dep-solve-fault-rolerant-cache

Conversation

@Anton-Latukha

@Anton-Latukha Anton-Latukha commented Dec 23, 2021 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Collaborator

This solves the build all problem when all projects can't infer the consitent
package version.

Also would allow caching workflow on manual start - to work & cache in a broken
or complex PRs.

@Anton-Latukha
CI: caching: keep-going
ce21ee8 
This solves the `build all` problem when all projects can't infer the consitent
package version.

Also would allow caching workflow on manual start - to work & cache in a broken
or complex PRs.
jneira
jneira approved these changes Dec 23, 2021
View reviewed changes

@jneira jneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we have to build as many deps as possible, thanks!

@jneira jneira added merge me Label to trigger pull request merge and removed merge me Label to trigger pull request merge labels Dec 23, 2021
@jneira

jneira commented Dec 23, 2021

Copy link
Copy Markdown
Member

Still a draft, merge it when you consider

@Anton-Latukha

Anton-Latukha commented Dec 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Yes. @jneira, the main idea & strength is that PR checks (test & bench) are the checkgate of configuration consistency. & caching runs in already consistent master after that. That is why we can weaken the check rules in caching to increase caching, for master consistency was already insured before that.

But inside the PRs this same property allows building through failing parts of the project configuration like through butter & cache what is possible.

@Anton-Latukha
Anton-Latukha marked this pull request as ready for review December 23, 2021 19:56
@Anton-Latukha
Anton-Latukha marked this pull request as draft December 23, 2021 19:57
@Anton-Latukha

Anton-Latukha commented Dec 23, 2021

Copy link
Copy Markdown
Collaborator Author

Well. Wanted to investigate how to manually run caching workflow. Long story short - it is only possible from the internal branch (wanted to do a PR to myself in the fork, but found that an additional requirement is that the main branch already has that workflow).

@Anton-Latukha
Anton-Latukha marked this pull request as ready for review December 23, 2021 21:10
@Anton-Latukha Anton-Latukha added the merge me Label to trigger pull request merge label Dec 23, 2021
@mergify
mergify Bot merged commit ab8c52b into haskell:master Dec 23, 2021
@Anton-Latukha
Anton-Latukha deleted the 2021-12-23-all-dep-solve-fault-rolerant-cache branch December 23, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneira jneira jneira approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anton-Latukha @jneira