Enable aarch64-darwin in flake.nix#2561
Merged
mergify[bot] merged 2 commits intoJan 3, 2022
Merged
Conversation
Currently only GHC 8.10.7 builds on `aarch64-darwin` after this change
jneira
reviewed
Jan 2, 2022
jneira
left a comment
Member
There was a problem hiding this comment.
happy to see you here and thanks for fix the builds for that arch 🙂
lgtm but will wait for an actual nix user review to merge
berberman
approved these changes
Jan 3, 2022
berberman
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. It seems that GitHub actions don't support aarch64-darwin yet. Is there anyway to test the build?
Member
|
we are building aarch64-darwin in the gitlab repo, only for ghc-8.10.7, it would be matter to change the gitlab CI config to add a job using the flake and several ghcs haskell-language-server/.gitlab-ci.yml Line 211 in ee0a0cc but it can be done in another pr imo |
Collaborator
|
CircleCI builds awaited by the PR are not present at the dashboard queue. |
Collaborator
|
[skip circleci] |
michaelpj
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only GHC 8.10.7 builds on
aarch64-darwinafter this change