GHC-9.0 support for hls-tactics-plugin#2581
Merged
Merged
Conversation
It compiles and most tests succeed, but some fail. In particular, the ones where it should suggest `show` fails to find that as a possible solution and fails to find evidence for `Show a`.
Previously when wingman fails to find a solution, the test failure would say "Timed out when waiting for a message". Now it instead prints the error message from wingman.
isovector
force-pushed
the
anka-213-tactics-ghc90
branch
2 times, most recently
from
January 13, 2022 18:19
0428385 to
ec8e439
Compare
pepeiborra
approved these changes
Jan 17, 2022
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Awesome, thanks @isovector
jneira
reviewed
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fork of @anka-213's #2202 that makes all the tactics tests pass! 🎉
The only issue is what to do about 9.2 support, which is broken by the compatibility layer here.