Fix progress eval test randomly failing#2590
Merged
pepeiborra merged 2 commits intoJan 15, 2022
Merged
Conversation
pepeiborra
approved these changes
Jan 15, 2022
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! The effort invested in fixing these subtle flaky tests often goes unnoticed so please accept my unlimited gratitude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2578.
Took way too long to find for how simple it was. The issue was that
getCodeLenseswas occasionally eating progress create messages, which caused any further messages with the same progress tokens to fail.The implemented fix is to expect progress messages up to the point of the code lens response, do whatever we need the code lens response for, then pass the currently active progress tokens to the final expect progress messages function finishing up the expectations.
The other progress tests should be fine since they don't eat messages.