[ghc-9.2] Fix rename plugin#2593
Merged
Merged
Conversation
We already have a cached delta AST at hand
pepeiborra
force-pushed
the
fix-rename-plugin
branch
from
January 16, 2022 10:05
bfc0605 to
b9d4ce9
Compare
pepeiborra
force-pushed
the
fix-rename-plugin
branch
from
January 16, 2022 16:19
b9d4ce9 to
01c60ad
Compare
pepeiborra
force-pushed
the
fix-rename-plugin
branch
from
January 16, 2022 16:55
01c60ad to
895d5ec
Compare
pepeiborra
marked this pull request as ready for review
January 16, 2022 18:06
jneira
approved these changes
Jan 16, 2022
jneira
left a comment
Member
There was a problem hiding this comment.
lgtm, one more plugin for ghc-9.2.1, yay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename plugin relies on SYB to find located AST trees that need renaming. This breaks in GHC 9.2 because the representation of located AST trees has changed: it now includes exactprint annotations.
To make the rename plugin work in 9.2, we need to adjust the SYB queries to look for the new located AST types.