Fix module-name plugin on ghc-9.2.1#2594
Merged
Merged
Conversation
jneira
approved these changes
Jan 16, 2022
jneira
left a comment
Member
There was a problem hiding this comment.
many thanks for including the plugin for 9.2.1, let's see if CI tests are happy and merge
jneira
reviewed
Jan 16, 2022
Also enables the plugin
Member
|
Tests are ok and changes looks good, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual fix mimics changes from #2503 ; config changes indiscriminately turn building with module-name on ghc-9.2.1 on.
I assume that bumping minor version of the plugin is useful for constraint configuration.
(AFAIU building 9.2.1 with stack is not ready yet, but why not turn module-name on in there too, in preparation.)