Skip to content

Remove duplicate help messages & format CRLF to LF#2709

Merged
pepeiborra merged 2 commits into
haskell:masterfrom
July541:duplicate-help
Feb 13, 2022
Merged

Remove duplicate help messages & format CRLF to LF#2709
pepeiborra merged 2 commits into
haskell:masterfrom
July541:duplicate-help

Conversation

@July541

@July541 July541 commented Feb 13, 2022

Copy link
Copy Markdown
Collaborator

This pr includes:

  1. close Duplicate entry in lsp --help #2703, it is because getArguments binds helper for all parser:
    opts = info ((
    VersionMode <$> printVersionParser exeName
    <|> probeToolsParser exeName
    <|> listPluginsParser
    <|> BiosMode <$> biosParser
    <|> Ghcide <$> arguments plugins
    <|> flag' PrintLibDir (long "print-libdir" <> help ("Print project GHCs libdir"))
    )
    <**> helper)
  2. Restore LF format

@July541
July541 requested a review from pepeiborra as a code owner February 13, 2022 07:05

@pepeiborra pepeiborra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra
pepeiborra merged commit ec5f235 into haskell:master Feb 13, 2022
@July541
July541 deleted the duplicate-help branch February 14, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate entry in lsp --help

2 participants