Fix 2 space leaks#2774
Merged
Merged
Conversation
Collaborator
Author
|
I found a second space leak, this time in the Before
After
|
Collaborator
|
What do you think about just turning on StrictData everywhere? |
fendor
approved these changes
Mar 14, 2022
Collaborator
Author
I am a big fan. |
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
* Fix a space leak in hls-graph * Fix leak in ExportsMap and optimize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a space leak in hls-graph by running the edit benchmark with
+RTS -hcto track down the monotonically increasing cost centre and then trying various things until ultimately locating the source of the leak.The thing that helped ultimately was an info table profile (
-hi), only available with ghc 9.2.2 and requires building with-finfo-table-map -fdistinct-constructor-tables). Thanks @mpickering and @HasuraHQ for contributing this profiling mode!Command line, for reference:
Before
After