Allow import all constructors#2782
Merged
Merged
Conversation
Collaborator
Author
|
With import A (A(B))
f = Cit will cause |
Collaborator
|
This is a good idea, thanks for working on it! |
Collaborator
Did you consider checking if |
July541
force-pushed
the
all-constructors-import
branch
from
March 19, 2022 06:00
1c9c1b1 to
77def21
Compare
pepeiborra
approved these changes
Mar 19, 2022
pepeiborra
left a comment
Collaborator
There was a problem hiding this comment.
Fantastic work, thank you @July541 !
July541
added a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
* Import all constructors * Rewrite the test * Exact print wildcard * Rerun circleci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #2734
Brief intro:
With
it will suggest import
Foo(..)now, likeimport A(Foo(..))andAdd Foo(..) to the import list of A.Note:
Support Now!
This doesn't work for record fields, ideally, we should support this.Example:
if we have
f = a, we should also haveimport A(Foo(..)). Maybe we can extendhaskell-language-server/ghcide/src/Development/IDE/Types/Exports.hs
Lines 64 to 70 in 621c2bb
with a field to indicate
a's data type ifais a record field.