Skip to content

Restore concise type variables in ghc-9.2#2828

Merged
mergify[bot] merged 4 commits into
haskell:masterfrom
July541:concise-type-variable
Apr 14, 2022
Merged

Restore concise type variables in ghc-9.2#2828
mergify[bot] merged 4 commits into
haskell:masterfrom
July541:concise-type-variable

Conversation

@July541

@July541 July541 commented Apr 14, 2022

Copy link
Copy Markdown
Collaborator

Close #2716.

GHC 9.2 changed the default showSDocUnsafe style from defaultUserStyle to defaultDumpStyle. This pr force showGhc with defaultUserStyle, hierarchy calling result shows the following functions are affected, but only atPoint(The function returns type varibale) really render IfaceType type.

image

@July541
July541 requested a review from pepeiborra as a code owner April 14, 2022 07:43
@July541
July541 force-pushed the concise-type-variable branch from 4930486 to 95e0ff5 Compare April 14, 2022 08:17
@July541
July541 force-pushed the concise-type-variable branch from 95e0ff5 to ebac11c Compare April 14, 2022 08:23
@michaelpj

Copy link
Copy Markdown
Collaborator

Nice, this is a good fix, but I wonder if we need to audit all the uses of showSDocUnsafe, like @hsyl20 suggested? Or do you think this covers the cases that matter?

@July541

July541 commented Apr 14, 2022

Copy link
Copy Markdown
Collaborator Author

Nice, this is a good fix, but I wonder if we need to audit all the uses of showSDocUnsafe, like @hsyl20 suggested? Or do you think this covers the cases that matter?

We have a lot of duplicate showSDocUnsafe and its alias, it is not easy to make a proper assessment. If you don't mind, we can merge this first, and I'll open another pr to sort out these shows.

@michaelpj

Copy link
Copy Markdown
Collaborator

If you don't mind, we can merge this first, and I'll open another pr to sort out these shows.

Totally happy with that, I just don't want us to forget, since it seems worrying! If you're thinking about it then that's great :)

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Apr 14, 2022
@mergify
mergify Bot merged commit 2da5931 into haskell:master Apr 14, 2022
@July541
July541 deleted the concise-type-variable branch April 14, 2022 15:25
@July541 July541 mentioned this pull request Apr 16, 2022
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request May 21, 2022
* Unify ppr style

* Fix test

* Compatible changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

complex type variables in hover with GHC 9.2

2 participants