Skip to content

Fix rename capability being declared#285

Merged
lukel97 merged 1 commit into
haskell:masterfrom
lukel97:fix-dud-rename-provider
Aug 4, 2020
Merged

Fix rename capability being declared#285
lukel97 merged 1 commit into
haskell:masterfrom
lukel97:fix-dud-rename-provider

Conversation

@lukel97

@lukel97 lukel97 commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

When there are no plugins provided that provide a pluginRenameProvider
This also applies to the other capabilities
Fixes #190

When there are no plugins provided that provider a pluginRenameProvider
This also applies to the other capabilities
@lukel97
lukel97 requested a review from pepeiborra August 4, 2020 12:30

@pepeiborra pepeiborra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ailrun Ailrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now our errors are more reliable!

@lukel97
lukel97 merged commit 7b6efe8 into haskell:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename fails

3 participants