Fix hover format#2911
Conversation
michaelpj
left a comment
There was a problem hiding this comment.
Can we get some comments explaining the place where we need to be careful about newlines? Otherwise we're going to lose the knowledge you just generated!
| ] | ||
| where maybeKind = fmap printOutputable $ safeTyThingType =<< lookupNameEnv km n | ||
| pretty Nothing Nothing = Nothing | ||
| pretty (Just define) Nothing = Just $ define <> "\n" |
There was a problem hiding this comment.
Completely independent of this PR, but I wonder if we'd make our lives easier by using prettyprinter for some of this stuff 🤔
There was a problem hiding this comment.
Unfortunately, I have little knowledge about prettyprinter... Maybe I'll improve this someday or any other can pick this...
Yes! all markdown-based content should be treat with care, I'll push more comment to explain what happened now. |
* Fix hover format * Test with regex * Add comments about inserting a new line in Markdown
Close #2863.
It is because markdown newline requires two '\n' but a separate section only needs one '\n'.