Return nothing if tool is not on the PATH#309
Merged
Conversation
Collaborator
Author
|
cc @horus does this fix it for you? |
lukel97
approved these changes
Aug 11, 2020
lukel97
left a comment
Collaborator
There was a problem hiding this comment.
Whoops, I had it in my head that readProcessWithExitCode would have returned a non zero exit code if it wasn't on the PATH. Too hasty code review lol
Collaborator
Author
|
@bubba I was thinking the same. The problems of having no tests for a new functionality :( |
Yes. I can confirm this PR solved my problem. |
Collaborator
Author
|
@horus Thank you for verifying! |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Sep 6, 2020
pepeiborra
added a commit
that referenced
this pull request
Dec 27, 2020
* code action to insert new definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered by #306 (comment), I forgot to actually check that a tool is on the path!
Therefore, currently HLS breaks for everyone who built it from source since the commit 0b12fcb and has not every tool installed.