Fix #3047#3092
Merged
Merged
Conversation
Collaborator
Author
|
/cc @andrewufrank |
fendor
requested changes
Aug 11, 2022
Collaborator
|
Excuse me for this drive-by review, I was just looking at it and found the usage of |
Collaborator
Author
I'll try to evaluate the usage of |
fendor
approved these changes
Aug 13, 2022
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
Sep 12, 2022
* Make path canonicalized * Update extra-source-files * Replace with normalise * Change to a more detailed log * Comment patch detail * 2 spaces indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is because of the difference between
hs-source-dirs: ./andhs-source-dirs: ., take/user/project/Lib/A.hsas example,hs-source-dirs: ./hs-source-dirs: .The canonicalized project path will be used as the prefix for
/user/project/Lib/A.hsCanonicalized it to prevent dropping one more character.