Send begin progress message synchronously#3110
Merged
Merged
Conversation
Currently the Begin progress message is sent asynchronously, so it can happen that it's never sent if the async is cancelled immediately because a new kick has started. This causes trouble in tests and benchmarks which make assumptions about progress updates. To address this, we send the Begin progress message synchronously, and only then do the rest of the progress reporting stuff (including waiting for the response) asynchronously
pepeiborra
marked this pull request as ready for review
August 17, 2022 21:27
wz1000
approved these changes
Aug 18, 2022
wz1000
enabled auto-merge (rebase)
August 18, 2022 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Begin progress message is sent asynchronously, so it can
happen that it's never sent if the async is cancelled immediately
because a new kick has started. This causes trouble in tests and
benchmarks which make assumptions about progress updates.
To address this, we send the Begin progress message synchronously,
and only then do the rest of the progress reporting stuff
(including waiting for the response) asynchronously