Log plugin name and attribute errors to plugins

[pepeiborra]

Here's another PR to make our logs slightly less useful: include the plugin name in plugin log messages and handler error messages. While there I also lowered the priority of some plugin log messages.

The end result can be seen in the log lines below.

2022-09-18T17:03:12.866214Z | Warning | retrie: InternalError: typecheck
2022-09-18T17:03:12.867001Z | Warning | retrie: InternalError: typecheck
2022-09-18T17:03:12.867141Z | Warning | retrie: InternalError: typecheck
2022-09-18T17:03:12.867250Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.867558Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.868251Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.868727Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.869204Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.875347Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.875602Z | Warning | retrie: InternalError: typecheck
[Warn  - 7:03:12 PM] retrie: InternalError: typecheck
2022-09-18T17:03:12.876245Z | Warning | class: InternalError: Unable to typecheck
[Warn  - 7:03:12 PM] class: InternalError: Unable to typecheck

Logs are still way too noisy as we log a warning when a plugin handler returns a ResponseError. I suspect that some plugins are generating ResponseErrors for things that are not really errors.

[drsooch]

Logs are still way too noisy as we log a warning when a plugin handler returns a ResponseError. I suspect that some plugins are generating ResponseErrors for things that are not really errors.

Agreed when I originally made the change I didn't really expect to see some of the errors (like failing to typecheck or get a parsed module).

I think sending back a ResponseError should more be in line with a logic bug or an unexpected code path. (Some of my plugins are guilty of sending a ResponseError when it probably shouldn't.)

[drsooch]

LGTM