Use nixpkgs variants of Sphinx packages#3227
Merged
Merged
Conversation
This commit replaces manually specified `myst-parser` and `sphinx_rtd_theme` packages with their counterparts already packaged on nixpkgs. With this change, `poetry2nix` is no more used, therefore that is removed as well.
ozkutuk
requested review from
berberman,
guibou and
michaelpj
as code owners
September 27, 2022 07:45
michaelpj
approved these changes
Sep 27, 2022
michaelpj
left a comment
Collaborator
There was a problem hiding this comment.
Excellent, thank you. I think myst_parser was not in nixpkgs when I wrote this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3211
This PR replaces manually specified
myst-parserandsphinx_rtd_themepackages with their counterparts already packaged on nixpkgs. With this change,poetry2nixis no more used, therefore that is removed as well.The documentation build via Nix (
nix build .#docs) still fails. However, the cause of failure is not related to the Nix infrastructure, but a warning in the documentation source. Nix build of the documentation promotes warnings to errors, hence the failure. We need to either lift this restriction, or actually fix the warning. Either way, that should be handled in a separate PR.