Skip to content

feat(git): Add install/hie.yaml to gitignore#328

Merged
jneira merged 1 commit into
haskell:masterfrom
sir4ur0n:feat/gitignoreInstallHieYaml
Aug 16, 2020
Merged

feat(git): Add install/hie.yaml to gitignore#328
jneira merged 1 commit into
haskell:masterfrom
sir4ur0n:feat/gitignoreInstallHieYaml

Conversation

@sir4ur0n

Copy link
Copy Markdown
Collaborator

Closes #326

@Ailrun Ailrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@sir4ur0n

Copy link
Copy Markdown
Collaborator Author

I think build failed for an unrelated reason, if anyone can restart it?

@jneira

jneira commented Aug 16, 2020

Copy link
Copy Markdown
Member

Maybe we could ignore all possible hie.yaml's in the code base with:

**/hie.yaml

?

@sir4ur0n I've reran the build!

@sir4ur0n

Copy link
Copy Markdown
Collaborator Author

Maybe we could ignore all possible hie.yaml's in the code base with:

**/hie.yaml

?

I thought about it but then thought "What if in the future some (integration?) tests want to test hie.yaml integration?".

If you prefer though, I can switch to wildcard hie.yaml rather than absolute paths, let me know!

@jneira

jneira commented Aug 16, 2020

Copy link
Copy Markdown
Member

I thought about it but then thought "What if in the future some (integration?) tests want to test hie.yaml integration?".

good point, better being cautious

@jneira
jneira merged commit ce9219d into haskell:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add install/hie.yaml to .gitignore

3 participants