Skip to content

Fix lower ghcide bounds of rename and fourmolu plugins#3501

Merged
mergify[bot] merged 3 commits into
masterfrom
fix-usePropertyAction-lower-bounds
Feb 24, 2023
Merged

Fix lower ghcide bounds of rename and fourmolu plugins#3501
mergify[bot] merged 3 commits into
masterfrom
fix-usePropertyAction-lower-bounds

Conversation

@pepeiborra

Copy link
Copy Markdown
Collaborator

These plugins depend on the usePropertyAction api that was introduced first in ghcide 1.9

@pepeiborra

Copy link
Copy Markdown
Collaborator Author

I have published Hackage revisions already

@georgefst georgefst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Feb 24, 2023
@mergify
mergify Bot merged commit 50799fe into master Feb 24, 2023
@georgefst

Copy link
Copy Markdown
Collaborator

Not that it really matters, but it just occurred to me that I thought I'd already fixed this in #3443. Perhaps I was misinformed about the version of ghcide in which usePropertyAction was added? Or maybe the problem is that that PR didn't have a corresponding Hackage revision.

wz1000 pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants