Skip to content

Don't show lenses for TH generated instances#3531

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
July541:th-no-lens
Mar 19, 2023
Merged

Don't show lenses for TH generated instances#3531
mergify[bot] merged 1 commit into
haskell:masterfrom
July541:th-no-lens

Conversation

@July541

@July541 July541 commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

Close #3319.

Long time no see!

Coming back with a minor improvement that cut off lenses for TH-generated instances.

@michaelpj You may be interested in this :)

@July541
July541 requested a review from Ailrun as a code owner March 18, 2023 17:18

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome, was just thinking yesterday that we shouldnt show these lenses!

@July541

July541 commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator Author

LGTM, awesome, was just thinking yesterday that we shouldnt show these instances!

The server kicked me off because of inactivation, but anyway, users will have a clear screen after the next release.

@fendor fendor added the merge me Label to trigger pull request merge label Mar 19, 2023
@mergify
mergify Bot merged commit b7cb765 into haskell:master Mar 19, 2023
@July541
July541 deleted the th-no-lens branch March 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lenses for type signatures for class methods appear even for generated classes

2 participants