Show package name and its version while hovering on import statements#3691
Merged
Conversation
fendor
approved these changes
Jul 26, 2023
Collaborator
Author
|
I'll merge this tomorrow if no more review here. |
Collaborator
Author
|
Nix build ran out of disks, can someone take a look? |
Collaborator
|
@July541 Failing nix CI is not blocking, so don't worry about it. It will likely get fixed during the next hackathon :) Rebasing the PR should be fine, imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HieFile doesn't have package information for import statements and we can't get package information from a simple
ModuleNamein a purity environment.This pr still uses
GHC.findImportedModuleto find package info from ghc env, andIOonly affect while hovering on import statements, so they are not expensive I think.