GHC 9.8 support#3727
Conversation
84e7d80 to
364eb95
Compare
|
All non exactprint plugins work and tests pass locally. I've added a CI job to test against 9.8-rc1. |
366ecb1 to
6aa2a66
Compare
michaelpj
left a comment
There was a problem hiding this comment.
Looks reasonable. Maybe @joyfulmantis as the CPP sherrif wants to take a look at the CPP.
| deepseq, | ||
|
|
||
| if impl(ghc >= 9.7) | ||
| repository head.hackage.ghc.haskell.org |
There was a problem hiding this comment.
I guess we can't really avoid this at the moment? I'm unsure how I feel about the prospect of us e.g. releasing binaries based on using packages from head.hackage 🤔 maybe it's fine
There was a problem hiding this comment.
No. I could use git dependencies instead by pushing head.hackage patches to forks, but I don't think it earns us much.
| 26021a13b401500c8eb2761ca95c61f2d625bfef951b939a8124ed12ecf07329 | ||
| 7541f32a4ccca4f97aea3b22f5e593ba2c0267546016b992dfadcd2fe944e55d | ||
|
|
||
| active-repositories: hackage.haskell.org, head.hackage.ghc.haskell.org |
There was a problem hiding this comment.
I think you don't need this
|
Incidentally, can we delete the allow-newers for older GHC versions now? |
fendor
left a comment
There was a problem hiding this comment.
LGTM, modulo the comments found by michael.
6d3635c to
6d22882
Compare
2af067b to
10549ff
Compare
Requires head.hackage to build
Requires head.hackage to build
Support for ghcide + non-exactprint plugins.