Add support for Fourmolu 0.14.0.0#3796
Merged
Merged
Conversation
Collaborator
|
You need to bump the |
brandonchinn178
force-pushed
the
fourmolu-0.14
branch
from
September 8, 2023 03:36
2617cf5 to
838695d
Compare
brandonchinn178
force-pushed
the
fourmolu-0.14
branch
from
September 8, 2023 04:00
838695d to
c655372
Compare
Contributor
Author
Nope 😄 Just pushed without testing. Sorry, just tested and it should work now |
Collaborator
|
I wondered but I didn't think you could have done the refactoring like that 😂 |
Contributor
Author
|
Just made good guesses in the refactor? 😂 Anyway, the test failures are unrelated. The Nix failure does seem relevant but I'm not sure how to update the Nix files |
Collaborator
|
I'm thinking is it possible to separate nix stuffs from the hls repo🤔️ |
Collaborator
|
That's why the check is not required :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was just released: https://github.com/fourmolu/fourmolu/releases/tag/v0.14.0.0
Also includes some minor refactoring. I think it should be pretty uncontroversial, but if not, I can break out into a separate PR