Skip to content

Add support for Fourmolu 0.14.0.0#3796

Merged
michaelpj merged 5 commits into
haskell:masterfrom
brandonchinn178:fourmolu-0.14
Sep 10, 2023
Merged

Add support for Fourmolu 0.14.0.0#3796
michaelpj merged 5 commits into
haskell:masterfrom
brandonchinn178:fourmolu-0.14

Conversation

@brandonchinn178

@brandonchinn178 brandonchinn178 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

This was just released: https://github.com/fourmolu/fourmolu/releases/tag/v0.14.0.0

Also includes some minor refactoring. I think it should be pretty uncontroversial, but if not, I can break out into a separate PR

@michaelpj michaelpj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@michaelpj

Copy link
Copy Markdown
Collaborator

You need to bump the index-state in cabal.project. I'm curious, did this build locally for you?

@brandonchinn178

Copy link
Copy Markdown
Contributor Author

You need to bump the index-state in cabal.project. I'm curious, did this build locally for you?

Nope 😄 Just pushed without testing. Sorry, just tested and it should work now

@michaelpj

Copy link
Copy Markdown
Collaborator

I wondered but I didn't think you could have done the refactoring like that 😂

@brandonchinn178

Copy link
Copy Markdown
Contributor Author

Just made good guesses in the refactor? 😂

Anyway, the test failures are unrelated. The Nix failure does seem relevant

       > Setup: Encountered missing or private dependencies:
       > fourmolu >=0.14 && <0.15

but I'm not sure how to update the Nix files

@July541

July541 commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

I'm thinking is it possible to separate nix stuffs from the hls repo🤔️

@michaelpj
michaelpj merged commit e6ac381 into haskell:master Sep 10, 2023
@michaelpj

Copy link
Copy Markdown
Collaborator

That's why the check is not required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants