Release 2.3.0.0#3818
Merged
Merged
Conversation
wz1000
requested review from
Ailrun,
Anton-Latukha,
kokobd,
konn and
ozkutuk
as code owners
September 27, 2023 12:52
wz1000
requested review from
July541,
OliverMadine,
VeryMilkyJoe,
berberman,
drsooch,
eddiemundo,
fendor,
georgefst,
pepeiborra and
santiweight
as code owners
September 27, 2023 12:52
fendor
approved these changes
Sep 27, 2023
fendor
left a comment
Collaborator
There was a problem hiding this comment.
Cabal and cabal-fmt plugin look good to me.
Collaborator
Author
|
Dropping the darwin nix CI changes because |
Collaborator
Author
|
Cirrus CI does not seem to be working. I will do the release without freebsd binaries. |
Collaborator
|
Should we merge this since it looks like you released? |
Member
|
Readthedocs doesn't seem updated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
.github/workflows/release.yamlghc: [to find all lists.TODO:to find locations that require extra care for GHC versions.*.cabalfiles (same version as hls)hie-compatrequires no automatic version bump.shake-benchis an internal testing tool, not exposed to the outside world. Thus, no version bump required for releases../GenChangelogs.hs <api-key> <tag><tag>is the git tag you want to generate the ChangeLog from.<api-key>is a github access key: https://github.com/settings/tokenswip/<version>git switch -c wip/<version><version>git tag <version>git push <remote> <version>sh scripts/release/download-gh-artifacts.sh <version> <your-gpg-email>gh-release-artifacts/haskell-language-server-<version>/gh-release-artifacts/haskell-language-server-<version>/cd gh-release-artifacts/haskell-language-server-<version>SIGNING_KEY=... ../../release/upload.sh uploadgpg --list-secret-keys --keyid-format=longhttps://downloads.haskell.org/~hls/haskell-language-server-<version>/SIGNING_KEY=... ../../release/upload.sh purge_allto remove CDN cachesghcup-0.0.7.yamlandghcup-vanilla-0.0.7.yamlsh scripts/release/create-yaml-snippet.sh <version>to generate a snippet that can be manually inserted into the yaml fileshls-metadata-0.0.1.jsoncabal run ghcup-gen -- generate-hls-ghcs -f ghcup-0.0.7.yaml --format json --stdoutin the root of ghcup-metadata repository