Fix multi unit session when some packages have reexported modules.#3928
Merged
Conversation
fendor
approved these changes
Jan 5, 2024
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, one comment needed.
wz1000
force-pushed
the
wip/multi-reexport
branch
from
January 5, 2024 12:12
bec3970 to
55d2e5f
Compare
fendor
approved these changes
Jan 5, 2024
wz1000
force-pushed
the
wip/multi-reexport
branch
from
January 8, 2024 08:48
ddf9ee3 to
1c05357
Compare
wz1000
force-pushed
the
wip/multi-reexport
branch
from
January 9, 2024 11:25
ac0f797 to
c6e27ca
Compare
fendor
enabled auto-merge
January 9, 2024 11:34
If we are loading multiple home packages, we need to explicitly take reexports into account when searching for target files. If we can't find a module via the usual mean, but it is listed as a reexport of a unit in scope, we need to look for the module from the perspective of that unit. This is not necessary for non-home modules because GHC already handles this for modules in the package DB. Unfortunately we can't fix this in GHC 9.2 because it doesn't support multiple home units and we have no way of knowing if a unit reexports modules
wz1000
force-pushed
the
wip/multi-reexport
branch
from
January 9, 2024 11:36
03c83f4 to
9a7b0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are loading multiple home packages, we need to explicitly take reexports
into account when searching for target files.
If we can't find a module via the usual mean, but it is listed as a reexport of
a unit in scope, we need to look for the module from the perspective of that unit.
This is not necessary for non-home modules because GHC already handles this for
modules in the package DB.
Unfortunately we can't fix this in GHC 9.2 because it doesn't support multiple
home units and we have no way of knowing if a unit reexports modules