[merge hls-test-utils and ghcide-test-utils] part of #4173 Migrate ghcide tests to hls test utils#4197
Merged
michaelpj merged 3 commits intoApr 30, 2024
Conversation
31 tasks
…ls-test-utils-ghcide-test
soulomoon
marked this pull request as ready for review
April 29, 2024 16:23
soulomoon
requested review from
fendor,
michaelpj and
pepeiborra
as code owners
April 29, 2024 16:23
Collaborator
|
Presumably we want to merge |
michaelpj
approved these changes
Apr 30, 2024
Collaborator
Author
Yes, after we cleanup the mess in our test suit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull ghcide-bench out of ghcide and merge some of the hls-test-utils with ghcide-tests.
Some running functions still remain in
ghcide-test-utils, but when all the tests migration is done, we can get rid ofghcide-test-utilsentirely