link executables dynamically to speed up linking#4423
Merged
Conversation
develop7
marked this pull request as ready for review
October 12, 2024 11:35
Collaborator
|
I am not sure what ramification this change might have. @wz1000 or @michaelpj, what do you think? |
develop7
force-pushed
the
feat-exec_dynamic
branch
from
October 29, 2024 17:53
5eeea2b to
992a3ad
Compare
wz1000
approved these changes
Jan 8, 2025
develop7
force-pushed
the
feat-exec_dynamic
branch
from
January 8, 2025 13:43
992a3ad to
ae5f23d
Compare
Collaborator
|
Thank you for the patience! We appreciate the contribution and the improved test execution times! |
Contributor
Author
Music to my ears! Feedback loop cannot be too short, period. |
This was referenced Apr 3, 2025
fendor
added a commit
to fendor/haskell-language-server
that referenced
this pull request
Apr 3, 2025
This reverts commit 2df8775.
fendor
added a commit
that referenced
this pull request
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dramatically decreases linking times and shaves 6 of 14G off HLS'
dist-newstyledirectory on my machine by producing way smaller executables.While
cabal building HLS after switching a branch I've noticed linking test executables takes minutes, plural, each. Then I've checked the size of a freshly-built test binary and it was 150-something megabytes, no wonder linker took a while. Withexecutable-dynamicenabled, linking is lightning fast and binaries are a megabyte at most, which should probably improve the developer experience and decrease the feedback loop time.UPD: #2659 seems related, not sure how up-to-date though