Documentation: HLS plugin tutorial improvements#4491
Merged
Conversation
fendor
approved these changes
Feb 9, 2025
Collaborator
There was a problem hiding this comment.
LGTM, thanks!
At some ZuriHac event, we had a contributor who invested quite some time into rewriting the tutorial since it is likely outdated: #3655. Iirc, it mostly stalled due to the desire to have automatic typechecking of the tutorial to avoid bit rot.
It'd be great if we could resurrect that PR at some point in the future.
dschrempf
force-pushed
the
doc-plugin-typos
branch
from
February 10, 2025 10:09
fbb0348 to
348678c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend the HLS plugin tutorial.
Some of these changes are opinionated, feel free to discuss or reject them.
@pepeiborra