Move ghcide-test to stand alone dir#4520
Merged
fendor merged 10 commits intoMar 19, 2025
Merged
Conversation
…to-a-stand-along-dir
…abal configuration
soulomoon
marked this pull request as ready for review
March 17, 2025 07:24
Collaborator
Author
|
Mainly some unfinished business refactoring the ghcide test. Two things are done. Move ghcide test files to a more correct location, a stand alone dir away from ghcide. |
soulomoon
enabled auto-merge (squash)
March 17, 2025 07:33
fendor
reviewed
Mar 17, 2025
soulomoon
disabled auto-merge
March 17, 2025 08:00
Collaborator
Author
|
Ready to go |
fendor
requested changes
Mar 18, 2025
fendor
left a comment
Collaborator
There was a problem hiding this comment.
One comment, otherwise LGTM!
fendor
approved these changes
Mar 18, 2025
fendor
enabled auto-merge (squash)
March 18, 2025 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #4519