Skip to content

reinstating ignore-plugins-ghc-bounds#4532

Merged
fendor merged 1 commit into
haskell:masterfrom
GuillaumedeVolpiano:master
Apr 1, 2025
Merged

reinstating ignore-plugins-ghc-bounds#4532
fendor merged 1 commit into
haskell:masterfrom
GuillaumedeVolpiano:master

Conversation

@GuillaumedeVolpiano

@GuillaumedeVolpiano GuillaumedeVolpiano commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

Seen from Gentoo, the ignore-plugins-ghc-bounds is useful, this patch tries to make it do something again.

gentoo-haskell/gentoo-haskell#1766

@fendor
fendor self-requested a review April 1, 2025 14:01

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I couldn't 100% tell from the discussion, does the Gentoo project have a particular use-case for this flag?

@GuillaumedeVolpiano

Copy link
Copy Markdown
Collaborator Author

Yep, the discussion was not very clear, but given the way ebuilds are structured, we need the same ebuild for every version of ghc (with a way of filtering plugins based on the version of ghc at the ebuild level). So basically, we pass the ignore-plugins-ghc-bounds so that these don’t interfere with our own filtering. Not sure I’m very clear.
Also, given the very nature of the distro (and our propension to patch things to make them work if they don’t), what actually works for us might be slightly different from the general use case: I’m still testing, but it seems that we have floskell working with ghc-9.12 here. So our filtering might be slightly different from yours.

Thanks for approving!

@fendor
fendor merged commit 32f7800 into haskell:master Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants