add ghcide-bench flag to .cabal file

[juhp]

Closes #4544

[fendor]

LGTM. Which issue does this close again?

[juhp]

Okay I created #4544: sorry if I didn't follow the proper workflow.
Do I need to reference the issue from the commit?

Also I wish this flag (as well as test-exe) would default to False: I didn't do this since I would rather not touch the CI, if you are using them in CI?? If not then they should definitely be off IMO.

(BTW might be good to have a PULL_REQUEST_TEMPLATE.md with a short checklist if you require certain things in PRs, just a suggestion :-)

[juhp]

Ugh why didn't github rebase...

[fendor]

No, it is fine, we don't follow a strict workflow, I thought we discussed this somewhere before... In #4359 actually!

Funnily enough, I started a similar PR in #4376 but kind of forgot about it. Could you check @soulomoon's comment from there?

[soulomoon]

Yes, benchmark is in CI, if you wish to turn it off by default, you need to modify the CI as well to explicitily enable it.

[fendor]

@soulomoon Looks like it worked? Does this look good then?

[soulomoon]

Look good to me