Skip to content

Remove allow-newer for hiedb#4551

Merged
mergify[bot] merged 5 commits into
masterfrom
jhrcek/rm-allow-newer-hiedb
Apr 8, 2025
Merged

Remove allow-newer for hiedb#4551
mergify[bot] merged 5 commits into
masterfrom
jhrcek/rm-allow-newer-hiedb

Conversation

@jhrcek

@jhrcek jhrcek commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

Using GHC 9.12 compatible version of hiedb released yesterday.

Comment thread .circleci/config.yml
jobs:
- stackage-lts22
- stackage-nightly
- stackage-lts23

@jhrcek jhrcek Apr 8, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current stackage nightly is using ghc-9.10.1.

So I renamed the job to lts-23 (based on ghc-8.10.4) to reflect reality of the current stack.yaml.
But now repo settings is expecting stackage-nightly job that doesn't exist.

To fix this we can:

  • bump nightly resolver to use ghc 9.10 (more work - I would prefer not doing that in this PR)
  • change repo settings not to expect stackage-nightly job as mandatory, but to expect stackage-lts23 (but I don't have permissions to fix repo settings)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the repo settings

@jhrcek
jhrcek marked this pull request as ready for review April 8, 2025 07:36
@jhrcek
jhrcek requested review from michaelpj and wz1000 as code owners April 8, 2025 07:36
@michaelpj

Copy link
Copy Markdown
Collaborator

I've just removed the stackage-nightly required check for now.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Apr 8, 2025
@mergify
mergify Bot merged commit 9474e78 into master Apr 8, 2025
@michaelpj

Copy link
Copy Markdown
Collaborator

Apparently mergify can't update it because it conflicts with master

@jhrcek
jhrcek deleted the jhrcek/rm-allow-newer-hiedb branch February 2, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Label to trigger pull request merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants