Skip to content

Mangoiv/improve key business#4654

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
MangoIV:mangoiv/improve-key-business
Jul 11, 2025
Merged

Mangoiv/improve key business#4654
mergify[bot] merged 1 commit into
haskell:masterfrom
MangoIV:mangoiv/improve-key-business

Conversation

@MangoIV

@MangoIV MangoIV commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes issue #4653

@MangoIV
MangoIV requested a review from wz1000 as a code owner July 10, 2025 09:39
@wz1000

wz1000 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

renderKey is pretty essential in large projects as it exists to ensure interning of Text strings that end up in diagnostics. When I last measured this we could be wasting tens to hundreds of megabytes on duplicated strings.

wz1000
wz1000 reviewed Jul 10, 2025
View reviewed changes
Comment thread hls-graph/src/Development/IDE/Graph/Internal/Key.hs Outdated
@MangoIV
MangoIV force-pushed the mangoiv/improve-key-business branch from ca14a80 to 10673e6 Compare July 10, 2025 09:52
@MangoIV

MangoIV commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Got it, thank you for the review @wz1000

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Jul 10, 2025
@fendor
fendor force-pushed the mangoiv/improve-key-business branch from 10673e6 to 7f0c412 Compare July 10, 2025 14:27
@mergify
mergify Bot merged commit 0a52558 into haskell:master Jul 11, 2025
50 of 52 checks passed
@fendor fendor mentioned this pull request Jul 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wz1000 wz1000 wz1000 approved these changes
@fendor fendor fendor approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MangoIV @wz1000 @fendor